-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add test for ESLint v9 #186
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #186 +/- ##
=======================================
Coverage 96.95% 96.95%
=======================================
Files 13 13
Lines 2102 2102
Branches 397 397
=======================================
Hits 2038 2038
Misses 63 63
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Line 68 in 0c21af5
|
Any plan to release a new version? |
This doesn't just add a test, it also fixes compatibility, right? |
I think it's already compatible with v9 ( |
Opened a separate PR for allowing ESLint 9 pre-releases, as that's what's needed for eg. @fisker to be unblocked with I will review this one separately as its about testing to ensure that we actually work as expected with it, which as you say @ota-meshi we should be 🙂 |
Should we drop support for ESLint 8 now? |
I think the work to drop support for ESLint v8 will probably be done in the alpha branch 😄 |
.. |
Thank you for checking out this PR, I will merge it. |
🎉 This PR is included in version 4.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
close #183