Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix crash when evaluating Symbol.prototype in getStringIfConstant #182

Merged
merged 11 commits into from
Mar 13, 2025

Conversation

fisker
Copy link

@fisker fisker commented Jan 4, 2024

No description provided.

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.65%. Comparing base (0c21af5) to head (71a2474).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #182      +/-   ##
==========================================
- Coverage   96.95%   96.65%   -0.31%     
==========================================
  Files          13       13              
  Lines        2102     2122      +20     
  Branches      397      399       +2     
==========================================
+ Hits         2038     2051      +13     
- Misses         63       68       +5     
- Partials        1        3       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fisker fisker marked this pull request as ready for review January 4, 2024 09:29
@fisker fisker changed the title Fix crash when evaluating Symbol.prototype fix:ix crash when evaluating Symbol.prototype Mar 11, 2025
@fisker fisker changed the title fix:ix crash when evaluating Symbol.prototype fix: fix crash when evaluating Symbol.prototype in getStringIfConstant Mar 11, 2025
@fisker fisker requested a review from ota-meshi March 11, 2025 07:35
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ota-meshi ota-meshi merged commit f3bc7a4 into eslint-community:main Mar 13, 2025
16 of 17 checks passed
@fisker fisker deleted the symbol-crash branch March 13, 2025 12:08
Copy link

🎉 This PR is included in version 4.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants