Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't initialize amoc_xmpp_presence twice (in helper and scenario) #44

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

chrzaszcz
Copy link
Member

@chrzaszcz chrzaszcz commented Feb 7, 2025

Prometheus raises an error mf_already_exists if you try to run the dynamic_domains_mam_lookup or dynamic_domains_inbox_lookup scenario.

Exometer didn't complain, so this duplicate init was unnoticed.

Prometheus raises an error 'mf_already_exists'.
Exometer didn't complain, so this duplicate init was unnoticed.
Copy link
Contributor

@NelsonVides NelsonVides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, nice 👌🏽

@NelsonVides NelsonVides merged commit 7379591 into master Feb 7, 2025
3 checks passed
@NelsonVides NelsonVides deleted the fix-duplicate-metrics branch February 7, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants