Feature/listeners #4452

NelsonVides · 2025-01-02T14:06:02Z

No description provided.

Note that components might register _any_ domain, even one not necessarily provided by a static config or a dynamically configured one. Hence it makes no sense to use the subdomains registration API as it was described in a TODO in `mod_disco:get_external_components/2`. Furthermore, when it comes to discovery, we want to leave all components as discoverable, regardless of whether the component is a subdomain of a static domain as it was previously done. The code filtering out unrelated parent domains comes from long before MongooseIM 1.0.0, as well as the option to set `extra_domains` to reenable visibility.

This option was used to make discoverable components that for a user might not have been discoverable given the domain was unrelated. This was so decided over a decade ago before MongooseIM 1.0.0, but I'd judge a better solution is to leave components as either entirely discoverable or entirely hidden by default, as components are usually dynamic and at the same time fully controllable at the deployment, and we can now have an infinite amount of domains for which a component can become a subdomain and hard-coding "extra_domains" for each static or dynamic domain is not feasible.

Xmpp services

codecov · 2025-01-02T14:17:30Z

Codecov Report

Attention: Patch coverage is 82.10766% with 236 lines in your changes missing coverage. Please review.

Project coverage is 85.60%. Comparing base (4ef2739) to head (702a559).

Files with missing lines	Patch %	Lines
src/s2s/mongoose_s2s_in.erl	71.01%	80 Missing ⚠️
src/component/mongoose_component_connection.erl	76.47%	48 Missing ⚠️
src/s2s/mongoose_s2s_out.erl	76.81%	48 Missing ⚠️
src/listeners/mongoose_xmpp_socket.erl	85.41%	14 Missing ⚠️
src/just_tls.erl	80.35%	11 Missing ⚠️
src/mongoose_addr_list.erl	91.13%	7 Missing ⚠️
src/c2s/mongoose_c2s.erl	89.79%	5 Missing ⚠️
src/mod_bosh_socket.erl	0.00%	3 Missing ⚠️
src/mod_websockets.erl	0.00%	3 Missing ⚠️
src/fast_auth_token/mod_fast_auth_token.erl	95.12%	2 Missing ⚠️
... and 12 more

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4452      +/-   ##
==========================================
+ Coverage   85.58%   85.60%   +0.02%     
==========================================
  Files         559      564       +5     
  Lines       34065    33840     -225     
==========================================
- Hits        29154    28969     -185     
+ Misses       4911     4871      -40

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Components/dynamic domains

Services in the context of MongooseIM means something else.

…of transforming at runtime

Rename components as components instead of the old services

Components/tls

Early data tests fail with exporter_master_secret_already_consumed

Ensure that they work

Fast auth and channel bindings This PR addresses "XEP-0484 Channel bindings for mod_fast_token_auth MIM-2380" Proposed changes include: New methods that support tls-exporter for channel binding tests 0rtt does not support channel binding with tls-exporter

mongoose-im · 2025-03-04T12:54:03Z

elasticsearch_and_cassandra_27 / elasticsearch_and_cassandra_mnesia / 19ef7ba
Reports root/ big
OK: 683 / Failed: 0 / User-skipped: 72 / Auto-skipped: 0

small_tests_27 / small_tests / 19ef7ba
Reports root / small

small_tests_26 / small_tests / 19ef7ba
Reports root / small

small_tests_27_arm64 / small_tests / 19ef7ba
Reports root / small

ldap_mnesia_26 / ldap_mnesia / 19ef7ba
Reports root/ big
OK: 2299 / Failed: 0 / User-skipped: 1187 / Auto-skipped: 0

dynamic_domains_mysql_redis_27 / mysql_redis / 19ef7ba
Reports root/ big
OK: 5139 / Failed: 0 / User-skipped: 154 / Auto-skipped: 0

ldap_mnesia_27 / ldap_mnesia / 19ef7ba
Reports root/ big
OK: 2299 / Failed: 0 / User-skipped: 1352 / Auto-skipped: 0

internal_mnesia_27 / internal_mnesia / 19ef7ba
Reports root/ big
OK: 2433 / Failed: 0 / User-skipped: 1218 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_27 / pgsql_mnesia / 19ef7ba
Reports root/ big
OK: 5174 / Failed: 0 / User-skipped: 119 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 19ef7ba
Reports root/ big
OK: 5009 / Failed: 0 / User-skipped: 119 / Auto-skipped: 0

pgsql_cets_27 / pgsql_cets / 19ef7ba
Reports root/ big
OK: 5248 / Failed: 0 / User-skipped: 188 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_27 / odbc_mssql_mnesia / 19ef7ba
Reports root/ big
OK: 5169 / Failed: 0 / User-skipped: 124 / Auto-skipped: 0

pgsql_mnesia_27 / pgsql_mnesia / 19ef7ba
Reports root/ big
OK: 5551 / Failed: 0 / User-skipped: 128 / Auto-skipped: 0

mysql_redis_27 / mysql_redis / 19ef7ba
Reports root/ big
OK: 5530 / Failed: 0 / User-skipped: 149 / Auto-skipped: 0

cockroachdb_cets_27 / cockroachdb_cets / 19ef7ba
Reports root/ big
OK: 5256 / Failed: 4 / User-skipped: 188 / Auto-skipped: 0

pubsub_SUITE:dag+last_item_cache:send_last_published_item_no_items_test

{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alice_send_last_published_item_no_items_test_3785@localhost/res1">>,
          escalus_tcp,<0.118750.0>,
          [{event_manager,<0.118731.0>},
           {server,<<"localhost">>},
           {username,
             <<"alicE_send_last_published_item_no_items_test_3785">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.118731.0>},
            {server,<<"localhost">>},
            {username,
              <<"alicE_send_last_published_item_no_items_test_3785">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"alice_send_last_published_item_no_items_test_3785">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,fun escalus_auth:auth_plain/2},
           {wspath,undefined},
           {username,
             <<"alicE_send_last_published_item_no_items_test_3785">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"37092a493ef13008">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {pubsub_tools,receive_response,3,
       [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
        {line,434}]},
     {pubsub_tools,receive_and_c...

Feature/listeners #4452

Are you sure you want to change the base?

Feature/listeners #4452

Conversation

NelsonVides commented Jan 2, 2025

This comment was marked as outdated.

codecov bot commented Jan 2, 2025 • edited Loading

Codecov Report

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

mongoose-im commented Mar 4, 2025 • edited Loading

mongoose-im commented Mar 5, 2025 • edited Loading

mongoose-im commented Mar 12, 2025 • edited Loading

mongoose-im commented Mar 13, 2025 • edited Loading

mongoose-im commented Mar 17, 2025 • edited Loading

mongoose-im commented Mar 19, 2025 • edited Loading

codecov bot commented Jan 2, 2025 •

edited

Loading

mongoose-im commented Mar 4, 2025 •

edited

Loading

mongoose-im commented Mar 5, 2025 •

edited

Loading

mongoose-im commented Mar 12, 2025 •

edited

Loading

mongoose-im commented Mar 13, 2025 •

edited

Loading

mongoose-im commented Mar 17, 2025 •

edited

Loading

mongoose-im commented Mar 19, 2025 •

edited

Loading