timers are not always stopped when leaving a page #583
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the bug
When leaving a page, the associated timer-sequence continues.
In some cases, returning to the page starts a new timer, causing multiple timers to be active.
To Reproduce
tbd
Expected behaviour
Page/panel-related timers must be stopped when leaving the page.
See e.g.
options.js
. functiononHide
.Additional context
one positive factor: most timer-sequences are not infinite sequences.
proposal to create panelTimerHelper function.
timer is registered in Panel.
timer is disabled when
isFinished
=true, or whenonHide
is calledparameters:
isFinished
=true