Skip to content

Commit

Permalink
Readme updated
Browse files Browse the repository at this point in the history
  • Loading branch information
ziopio committed Jan 24, 2022
1 parent ec36c13 commit 3cd1df8
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 6 deletions.
10 changes: 6 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,12 @@ Prototype for a ROS2 implementation in pure Erlang.

## Requirements:
Erlang OTP 23 as minimum
ROS2 foxy
Cyclone DDS
ROS2 galactic

Note: current implementation has been tested only against cyclone dds.

Note:
The current implementation has only been tested against Cyclone-dds.
If you are using a different middleware for ROS2 you could experience crashes.

## Build

Expand All @@ -24,7 +26,7 @@ Note: current implementation has been tested only against cyclone dds.
rebar3 shell --apps talker
RMW_IMPLEMENTATION=rmw_cyclonedds_cpp ros2 run demo_nodes_py listener
### Turtle controller
Write commands on the shell to send them to the turtle on screen.
Write commands on the shell to send them to the turtle on the screen.

# LAUNCH:
rebar3 shell --apps turtle_controller
Expand Down
2 changes: 1 addition & 1 deletion demos/minimal_service/src/minimal_service.erl
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ on_client_request(Pid, {_, R}) ->
gen_server:call(Pid, {handle_request, R}).

init(S) ->
Node = ros_context:create_node("minimal_server"),
Node = ros_context:create_node("minimal_service"),

Service =
ros_node:create_service(Node, example_interfaces_add_two_ints_srv, {?MODULE, self()}),
Expand Down
3 changes: 2 additions & 1 deletion demos/parameters/src/parameters.erl
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,14 @@
start_link() ->
gen_server:start_link(?MODULE, #state{}, []).

% TODO: develop an interesting demo around parameter events and services
init(_) ->
Node = ros_context:create_node("parameter_test"),

OtherNode = ros_context:create_node("second_node"),

ok = ros_context:destroy_node(OtherNode),

{ok, #state{ros_node = Node}}.

handle_call(_, _, S) ->
Expand Down

0 comments on commit 3cd1df8

Please sign in to comment.