Do not search over all repos when an argument is provided #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple repositories are found, we require a repository argument. However, this is at adds with the
whoamicommand. Originally this was written to perform awhoamifor each repository in state, and the bug was introduced when we switched to requiring a repo argument, such that if you have multiple repos defined, this would never work or would only partially work in the best case.While this small PR is a quick fix, we may alternatively adjust the task to conditionally require the repo argument depending on the task, and in fact I'm leaning more that way :) However, I figured this PR could serve as an issue to discuss both approaches.