Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with hex cut when no -i option is given (#316) #317

Merged
merged 1 commit into from
Jan 28, 2023
Merged

Fix issue with hex cut when no -i option is given (#316) #317

merged 1 commit into from
Jan 28, 2023

Conversation

saleyn
Copy link
Contributor

@saleyn saleyn commented Jan 25, 2023 •
edited
Loading

The -i (increment) option is documented as optional but when not passed, it crashes hex cut. This fix makes it optional.

@saleyn saleyn changed the title Fix issue when no option is given (#316) Fix issue with hex cut when no -i option is given (#316) Jan 25, 2023
@ferd ferd requested a review from starbelly January 25, 2023 15:15
ferd
ferd approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member

@ferd ferd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks valid to me. Broken CI unrelated it seems.

@starbelly
Copy link
Member

This looks good, CI failure is unrelated but cut currently isn't covered anyway, so will YOLO merge this one. Thanks! ❤️

@starbelly starbelly merged commit 6ed1b09 into erlef:main Jan 28, 2023
@starbelly starbelly mentioned this pull request Jan 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferd ferd ferd approved these changes

@starbelly starbelly Awaiting requested review from starbelly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saleyn @starbelly @ferd