Don't require repo arg for building under certain conditions #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferd
reviewed
Mar 28, 2022
src/rebar3_hex_build.erl
Outdated
| Task when Task =:= undefined orelse Task =:= "docs" -> | ||
| case has_no_doc_provider(State, Repos) of | ||
| true -> | ||
| #{name => repo_not_set}; |
There was a problem hiding this comment.
name could be anything, but we have a clause for doc_opts/1 that matches on a map with name in it. I figured if we crash with passing this around, there's only one place it would be set.
There was a problem hiding this comment.
Note : I'm going to adjust this, it's hacky.
starbelly
force-pushed
the
conditional-repo-req-on-build
branch
from
46f7383 to
4d11955
Compare
|
@ferd I squashed and forced pushed
|
Most cases for using the build provider shouldn't require specifying a repo argument. The exception is when there is more than one repo found and at least one has doc config set on the repo. In addition, configuring documentation providers within repo config is deprecated and a warning will be emitted if such config is detected.
starbelly
force-pushed
the
conditional-repo-req-on-build
branch
from
4d11955 to
4ddca38
Compare
ferd
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most cases for using the build provider shouldn't require specifying a repo argument.
The exception is when there is more than one repo found and at least one has doc config set on the
repo.