Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build command should not require repo argument #299

Closed
farhadi opened this issue Jan 24, 2022 · 1 comment · Fixed by #303
Closed

build command should not require repo argument #299

farhadi opened this issue Jan 24, 2022 · 1 comment · Fixed by #303

Comments

@farhadi
Copy link

farhadi commented Jan 24, 2022

We are using rebar3 hex build command to build packages for our self-hosted hex repo, but since we have multiple repos defined in rebar.config, rebar3 hex build complains that "A repository argument is required", but since build command only builds the package and doesn't publish it to the repo, I think this repo argument can be removed from build command, right?
@starbelly
Copy link
Member

So, the reason it's required is because someone can define a doc provider on a per repository basis. That said, I think what we can do is check to see if there are

  1. multiple repos
  2. If any of them have doc provider config

If 1 and 2 hold true, raise an error instructing the user to provide a repo argument, otherwise, continue.

@starbelly starbelly linked a pull request Mar 28, 2022 that will close this issue
Don't require repo arg for building under certain conditions #303
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't require repo arg for building under certain conditions starbelly/rebar3_hex
2 participants
@farhadi @starbelly