New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev fix review items #203

Merged

GeraldineGomez merged 229 commits into main from fix-review-items

Sep 18, 2024

Member

GeraldineGomez commented Jul 26, 2024

Please check if the PR fulfills these requirements

I have read the CONTRIBUTING guidelines
A new item has been added to NEWS.md
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)
Checks have been run locally and pass

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Includes:

R_user_dir for cache in the function import_data_event
Solve problems related to PR adding conditional for single color in plot by variable #20
Specify which population was used to calculate the incidence
Map for municipalities in Colombia case
Fix typos, accents and puctations

What is the current behavior? (You can also link to an open issue here)
Issue related Improve structure of the package #194
What is the new behavior (if this is a feature change)?

Specify which population was used to calculate the incidence
Map for municipalities in Colombia case

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No, it does.

Bisaloo and others added 30 commits

July 18, 2024 16:41


          Simplify and fix concatenar_vals_token()

28d32d4

Since until now, the loop continued beyond longitud if the string was longer


          Replace use of superseded _at() dplyr functions

ce1b0f7


          Remove duplicate ggplot theme specification

0e6a5c2


          Simplify nested paste0() calls

bc13e03


          Make arg defaults explicit

11a8a0f


          Use c() instead of append()

901dfc0


          Make code responsive to events_adicionales length

691cb4d


          Make sure input checking happens early enough

8703b4f


          Add comment to explicit the necessary of 'tam' arg

d331b62


          Use geom_col() rather than geom_bar()

a028071


          Rely on data.frame recycling of scalar where appropriate

596fd91


          Avoid reusing var name for two different object types

95418ae


          Read RDS files rather than RDA files

ab2201c


          Remove unnecessary parse(eval()) calls

5d423d4


          Remove input checking in internal functions

6d3dd4c

As discussed with Geraldine


          Simplify obtener_fila_mas_casos()

34894f1


          Remove always TRUE condition

9c2242e


          Use orientation = "y" instead of coord_flip()

0ad6c54


          Remove unneeded special handling of edge cases

a5d321a


          Remove unnecessary initializations

b9d3d93


          Simplify special casing of Malaria

e1b3a86


          Remove non-existing argument in toString()

b14914b


          Ensure connection is always closed

72ba167


          Exit early on edge case

86b927b


          Avoid growing vectors in loops

c55e306


          Copy infrastructure files from packagetemplate

892f834


          Automatic readme update

4b325bb


          Copy infrastructure files from packagetemplate

6a2eee8


          Fix some typos

4d6218d


          Run styler::style_pkg()

0201c37


          chore: added spelling mkdir command

318b3db

Ref: #194

github-actions bot commented Aug 14, 2024

This pull request:

Adds 3 new dependencies (direct and indirect)
Adds 1 new system dependencies
Removes 0 existing dependencies (direct and indirect)
Removes 0 existing system dependencies

Reach out on slack (#code-review or #help channels) to double check if there are base R alternatives to the new dependencies.

(Note that results may be inaccurate if you branched from an outdated version of the target branch.)

GeraldineGomez added 2 commits

August 14, 2024 12:29


          chore: added windows folder for dicitiontaries

f463377

Ref: #194


          chore: restore spelling file

cd6b7a6

Ref: #194

github-actions bot commented Aug 14, 2024

This pull request:

Adds 3 new dependencies (direct and indirect)
Adds 1 new system dependencies
Removes 0 existing dependencies (direct and indirect)
Removes 0 existing system dependencies

Reach out on slack (#code-review or #help channels) to double check if there are base R alternatives to the new dependencies.

(Note that results may be inaccurate if you branched from an outdated version of the target branch.)

gsgomezm and others added 6 commits

September 18, 2024 10:14


          fix: validate Malaria Asociada parenthesis pattern

f557702


          fix: age range and validation

a968a2f


          chore: parametrization of code_eve reference

60a93f2


          chore(incidence): add cache parameter in functions to improve the per…

690caee

…fomance


          fix(agrupar_edad_sex): age validation

f40c1ac


          fix(import_data_event): add fec_def validation

cbbe783

github-actions bot commented Sep 18, 2024

This pull request:

Adds 3 new dependencies (direct and indirect)
Adds 1 new system dependencies
Removes 0 existing dependencies (direct and indirect)
Removes 0 existing system dependencies

Reach out on slack (#code-review or #help channels) to double check if there are base R alternatives to the new dependencies.

(Note that results may be inaccurate if you branched from an outdated version of the target branch.)

GeraldineGomez added 10 commits

September 18, 2024 11:41


          fix(plotting): automatization of plot scale based on column reference

2ad86ef


          chore: standardization of cod_eve reference

dd1dd81


          fix(limpiar_data_sivigila): age validations

4186c0b


          chore: update README file

d5d21b8


          chore(skeleton): add cache parameter reference in incidence function

aa7db16

Ref: #194


          chore(skeleton): standardization of nombre_evento and cod_eve column

b4b77ae


          chore: update documentation

d67803e


          fix(estandarizar_geo_cods): add validation of geo columns

ade3e5b


          chore(convert_edad): add others uni_med to convert the age

7ab39d1


          chore: remove spelling validation

aa55d24

github-actions bot commented Sep 18, 2024

This pull request:

Adds 3 new dependencies (direct and indirect)
Adds 1 new system dependencies
Removes 0 existing dependencies (direct and indirect)
Removes 0 existing system dependencies

Reach out on slack (#code-review or #help channels) to double check if there are base R alternatives to the new dependencies.

(Note that results may be inaccurate if you branched from an outdated version of the target branch.)


          chore: remove spelling

8ed0bfd

github-actions bot commented Sep 18, 2024

This pull request:

Adds 3 new dependencies (direct and indirect)
Adds 1 new system dependencies
Removes 0 existing dependencies (direct and indirect)
Removes 0 existing system dependencies

Reach out on slack (#code-review or #help channels) to double check if there are base R alternatives to the new dependencies.

(Note that results may be inaccurate if you branched from an outdated version of the target branch.)


          fix: lintr space and lines

e8cf594

github-actions bot commented Sep 18, 2024

This pull request:

Adds 3 new dependencies (direct and indirect)
Adds 1 new system dependencies
Removes 0 existing dependencies (direct and indirect)
Removes 0 existing system dependencies

Reach out on slack (#code-review or #help channels) to double check if there are base R alternatives to the new dependencies.

(Note that results may be inaccurate if you branched from an outdated version of the target branch.)

GeraldineGomez merged commit 5b9cad2 into main

9 checks passed

GeraldineGomez deleted the fix-review-items branch

September 18, 2024 17:21

GeraldineGomez restored the fix-review-items branch

September 18, 2024 17:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet