remove samplerate, as it is superseded by tracesSampler #960
+0
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zwhitchcox
force-pushed
the
pr/remove-duplicate-samplerate
branch
2 times, most recently
from
e63f9f0 to
4dbf12f
Compare
zwhitchcox
force-pushed
the
pr/remove-duplicate-samplerate
branch
from
4dbf12f to
04890d5
Compare
kentcdodds
requested changes
Mar 7, 2025
| @@ -10,7 +10,6 @@ export function init() { | |||
| Sentry.init({ | |||
| dsn: process.env.SENTRY_DSN, | |||
| environment: process.env.NODE_ENV, | |||
| tracesSampleRate: process.env.NODE_ENV === 'production' ? 1 : 0, | |||
There was a problem hiding this comment.
I think it would make sense to move this prod check to the tracesSampler function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tracesSampleroverrides the flat sample rate:https://docs.sentry.io/platforms/javascript/configuration/sampling/#precedence
We already check if environment is in production with the SENTRY_ENABLED variable, so the production check is redundant