Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add alts to images #3983

Merged
merged 3 commits into from
Nov 6, 2023
Merged

add alts to images #3983

merged 3 commits into from
Nov 6, 2023

Conversation

rustam-mukhametshin
Copy link
Contributor

@rustam-mukhametshin rustam-mukhametshin commented Oct 26, 2023

Add alts to images

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

@m0ksem m0ksem self-requested a review November 3, 2023 15:00
Copy link
Collaborator

@m0ksem m0ksem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I added few fixes.

I think list can be generally improved and have this kind of description:
image
But it would be nice to have in different issue, maybe requires VaList component update.

@m0ksem m0ksem added the docs packages/docs label Nov 6, 2023
@m0ksem m0ksem merged commit 876dc53 into epicmaxco:develop Nov 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs packages/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants