Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New consent popup UI #1610

Merged
merged 3 commits into from
Feb 18, 2025
Merged

feat: New consent popup UI #1610

merged 3 commits into from
Feb 18, 2025

Conversation

lourou
Copy link
Member

@lourou lourou commented Feb 18, 2025

Changes

  • Added full-width buttons in consent popups (DM and Group), removed icons
  • Added helper text below delete button to inform about notification behavior
  • Continued improving design system components for better reusability and consistency

Implementation Details

  • Created ConversationConsentPopupHelperText component in design system for consistent helper text styling
  • Updated button and container components to support full-width layout
  • Standardized spacing using theme values
  • Centralized text alignment for helper messages

Housekeeping

  • Gradually removed unused translations

Linked to #1589

Screenshot

@lourou lourou requested a review from a team as a code owner February 18, 2025 14:43
@@ -27,9 +45,12 @@ export function ConsentPopupButtonsContainer({
<VStack
style={[
{
flexDirection: "row",
flexDirection: "column",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed since it's a VStack it automatically has this property

@lourou lourou merged commit 5314d0c into main Feb 18, 2025
2 of 4 checks passed
@lourou lourou deleted the lr/consent-ui-popup branch February 18, 2025 15:00
technoplato pushed a commit that referenced this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants