Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added hyperlink to spaceall heatmap on status button #62

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added hyperlink to spaceall heatmap on status button #62

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions public/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ <h1>Entropia</h1>
</div>

<div class="club-status-wrapper">
<a href="https://mapall.space/heatmap/show.php?id=Entropia" target="_blank" rel="noopener noreferrer"></a>
<span class="club-status"></span>
Copy link
Member

@DO1JLR DO1JLR Sep 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich frag mal ganz naiv, sollte sich das </a> nicht eher nach dem <span class="club-status"></span> Schließen?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disclaimer, wenig Ahnung von HTML. Daher naiv zurückgefragt; wieso? Bzw kommt drauf an, so viel ich weiß?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Man möchte ja den Teil den man anklickt innerhalb des <a> tags haben. Und das ist ja eigentlich diese Club Status anzeige...

Beispiel:

<a href="http://example.com">Dieser Text führt nach example.com</a>

Copy link
Member

@pascalwittler pascalwittler Sep 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vielleicht ergänzend ein bisschen Kontext:

<span class="club-status"></span> ist das Element, in welches per Javascript nach Abfrage der SpaceAPI das Wort "geöffnet" bzw. "geschlossen" geschrieben wird und welches, ebenfalls per Javascript, eine zusätzliche Klasse erhält, um die grüne oder rote Hintergrundfarbe zu setzen.

Es könnte also auch das <span> durch den vorgeschlagenen <a>-Tag mit der Klasse club-status ersetzt werden.

</div>

Expand Down