Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow informative tests to produce skipped result #1292

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Allow informative tests to produce skipped result #1292

wants to merge 1 commit into from
+7 −0

Conversation

simonbaird
Copy link
Member

@simonbaird simonbaird commented Feb 10, 2025 •
edited
Loading

lcarva
lcarva requested changes Feb 11, 2025
View reviewed changes
Copy link
Member

@lcarva lcarva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An informative check is one that must complete successfully but may find issues/violations. If the check is skipped, it did not run successfully.

@simonbaird
Copy link
Member Author

An informative check is one that must complete successfully but may find issues/violations. If the check is skipped, it did not run successfully.

Yeah, you're right. I guess we could invent lib.rule_data("skippable_tests"), but even then a simple list is not enough to capture the idea that it's supposed to be skippable only when certain other conditions are met.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcarva lcarva lcarva requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonbaird @lcarva