feature/MakeDropdownTextDoubleClickable #153
Open
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubhrathasetty
approved these changes
Aug 20, 2024
tdegrunt
requested changes
Aug 20, 2024
| @@ -12,7 +12,7 @@ div.satis-dropdown data-action="keydown->satis-dropdown#dispatch" data-controlle | |||
| .h-12.p-1.flex.rounded | |||
| .flex.flex-auto.flex-wrap | |||
| / Input where you can search | |||
| input.p-1.px-2.appearance-none.outline-none.w-full.sts-dropdown-input.text-gray-800.dark:text-gray-300 data-action="input->satis-dropdown#search" data-satis-dropdown-target="searchInput" placeholder=placeholder autofocus=options[:autofocus] | |||
| input.text.p-1.px-2.appearance-none.outline-none.w-full.sts-dropdown-input.text-gray-800.dark:text-gray-300 data-action="input->satis-dropdown#search" data-satis-dropdown-target="searchInput" placeholder=placeholder autofocus=options[:autofocus] ondblclick="this.select()" | |||
There was a problem hiding this comment.
This needs to work with stimulus events (dblclick) and then trigger the select of the input. Don't put normal JS directly in html.
https://onrails.blog/2018/04/11/lets-make-an-editable-header-using-stimulus-js/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: https://github.com/boxture/server/issues/3272
Topbar dropdown is clickable wherever and double click selectable.
Page (table) dropdowns are now double clickable and this will select the entirety of the text the selection of specific place/drag selecting is blocked by the drag function on the dropdowns themselves, however changing cursor position can be done with arrows