Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/preview screen for import #19

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

shubhrathasetty
Copy link
Contributor

#16

@WaQasRPL
Copy link
Contributor

please resolve conflicts

@rparse
Copy link
Contributor

rparse commented Feb 1, 2024

As per ticket description, I guess after selecting excel file we need to show preview like below -

Screenshot 2024-02-01 at 4 04 00 PM (2)

currently you are showing like below -

Screenshot 2024-02-01 at 4 05 13 PM (2)

Please confirm!

@rparse rparse self-requested a review February 1, 2024 12:30
Copy link
Contributor

@rparse rparse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please confirm the requirement as per my comment, Thank you!

Copy link
Contributor

@tdegrunt tdegrunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, otherwise it seems fine

@rparse
Copy link
Contributor

rparse commented Feb 28, 2024

Tested and found below -

  1. If we are uploading blank file then no need to show preview screen/ further processing I guess or any message which states there is no data.

  2. If I upload blank file getting preview screen and after I click on upload getting below error - undefined method `reject’ for nil:NilClass
    Screenshot 2024-02-28 at 3 40 27 PM

  3. On staging if I upload uploaded product result sheet(Its accept as it is having same headers) excel it gives me this Exception: undefined method []' for nil..... On this branch if I upload uploaded product result sheet it gives me - preview screen as below and after upload gives this error - Exception: undefined method []' for nil:NilClass value = strip_tags(value.strip) if value.respond_to?(:strip) && columns[column]&.options[:strip_tags] != false ^^^^^^^^^^^^^
    Screenshot 2024-02-28 at 3 57 13 PM
    Thank you!

@shubhrathasetty
Copy link
Contributor Author

fixed above errors . thank you

@rparse
Copy link
Contributor

rparse commented Feb 29, 2024

  1. Preview structure is fine now, but one column is unselected even if it is having value, so I guess this will be in case of columns having false value (here import_errors column) or we can also disable this columns starting with "import_"
    Screenshot 2024-02-29 at 4 05 15 PM

  2. and after uploading result sheet file it is already uploaded then its give error in excel but with mismatch row and header format

Screenshot 2024-02-29 at 4 05 45 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants