feat(ses,module-source): Add ModuleSource shim #2463
+74
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #2252
Description
To test feature the degree of compatibility between a version of XS, XS with Endo shims, and Node.js with Endo shims, we need a shim for ModuleSource proper. This lets us create an environment with a global
ModuleSource
, whereModuleSource
is a shared intrinsic of all Compartments.This change both introduces the shim and the necessary accommodations for the existence of a global ModuleSource shared intrinsic in SES.
Security Considerations
The new ModuleSource is subject to hardening of shared intrinsics during SES lockdown. A failure to harden the shared intrinsic would lead to a potential for interference or communication between isolated compartments.
Scaling Considerations
None.
Documentation Considerations
None.
Testing Considerations
This includes a test for SES that verifies that ModuleSource is properly propagated and hardened.
Compatibility Considerations
None.
Upgrade Considerations
None.