feat(where): allow all paths to be set by env vars #2441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumavis
force-pushed
the
kumavis/feat-where-env
branch
from
f19bdbd
to
fac13aa
Compare
kriskowal
reviewed
Aug 30, 2024
There was a problem hiding this comment.
This is good, and I think it would also be good to have a single environment variable to fall back to if one of these isn’t specified. I think it has to be a name like export ENDO=alice since the Windows named pipe, in particular, can’t be in a subdirectory of a shared root with the others. The same limitation applies to temporary files, which should be on a tmpfs mount (RAM filesystem).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from #2279
part of a feature for easily creating new Endo daemons (eg for development)