fix(daemon): binding Promise breaks exo #2439
Open
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
kriskowal
approved these changes
Aug 30, 2024
| @@ -65,6 +65,8 @@ const hardenedEndowments = harden({ | |||
| TextEncoder, | |||
| TextDecoder, | |||
| URL, | |||
| // This one is important for exo to work. | |||
There was a problem hiding this comment.
@mhofman or @michaelfig can I ask you to help @kumavis expand this comment to explain why and where to look for more? I think this is the work of the handled promise shim, but I did not know it replaced globalThis.Promise.
There was a problem hiding this comment.
@endo/eventual-send does not mutate Promise in any way, so I'm confused as to why this line is necessary.
There was a problem hiding this comment.
I really don't understand why this is necessary. Is there anything in your environment that might be replacing the global Promise? Maybe some telemetry library?
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes Exo compatibility for Endo Daemon