test(ses): Coverage for module source validation #2434
Merged
+94
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kriskowal , is this still relevant? |
kriskowal
force-pushed
the
kriskowal-ses-invalid-module-source-coverage
branch
from
f7d19b7
to
eb502c2
Compare
Yes, this is still desirable and will inform tests for hardened262 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change increases coverage and consistency of error messages for invalid module sources.
Security Considerations
None.
Scaling Considerations
None.
Documentation Considerations
None.
Testing Considerations
It’s tests all the way down.
Compatibility Considerations
There is a possibility that this will break tests that are over-constrained on error messages.
Upgrade Considerations
None.