Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep sock original timeout, If read,write timeout not set #868

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iamdrq
Copy link

@iamdrq iamdrq commented Jan 5, 2024

Summary

In httpcore/_backends/sync.py, when not set timeout. It will override original sock timeout setting,this patch fixed it.

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant