Add marqueeOn prop to MarqueeController #2833
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
I have read and understand the contribution guide
A CHANGELOG entry is included
At least one test case is included for this feature or bug fix
Documentation was added or is not needed
This is an API breaking change
Issue Resolved / Feature Added
It's not currently possible to set the
marqueeOn
prop on a container, which then informs all of the children marquees.Resolution
This adds support to
MarqueeController
to support settingmarqueeOn
on the controller and having all of the children respond, unless they'd been given explicit instructions of their own.Additional Considerations
This branch is 6 months old. I figured I might as well open a PR.