Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add marqueeOn prop to MarqueeController #2833

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Djspaceg
Copy link
Member

Checklist

  • I have read and understand the contribution guide

  • A CHANGELOG entry is included

  • At least one test case is included for this feature or bug fix

  • Documentation was added or is not needed

  • This is an API breaking change

Issue Resolved / Feature Added

It's not currently possible to set the marqueeOn prop on a container, which then informs all of the children marquees.

Resolution

This adds support to MarqueeController to support setting marqueeOn on the controller and having all of the children respond, unless they'd been given explicit instructions of their own.

Additional Considerations

This branch is 6 months old. I figured I might as well open a PR.

@Djspaceg Djspaceg changed the title Feature/marqueeoncontroller Add marqueeOn to MarqueeController Jul 30, 2020
@codecov
Copy link

codecov bot commented Jul 30, 2020

Codecov Report

❗ No coverage uploaded for pull request base (develop@d95ecbb). Click here to learn what that means.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #2833   +/-   ##
==========================================
  Coverage           ?   44.75%           
==========================================
  Files              ?      163           
  Lines              ?     8244           
  Branches           ?     2013           
==========================================
  Hits               ?     3690           
  Misses             ?     3424           
  Partials           ?     1130           
Impacted Files Coverage Δ
packages/ui/Marquee/MarqueeController.js 4.21% <0.00%> (ø)
packages/ui/Marquee/MarqueeDecorator.js 65.07% <66.66%> (ø)
packages/i18n/src/dates.js 100.00% <0.00%> (ø)
packages/spotlight/src/target.js 40.30% <0.00%> (ø)
packages/ui/ViewManager/ViewManager.js 100.00% <0.00%> (ø)
packages/ui/Layout/Cell.js 100.00% <0.00%> (ø)
packages/ui/Touchable/config.js 100.00% <0.00%> (ø)
packages/ui/Scrollable/Scrollbar.js 0.00% <0.00%> (ø)
packages/ui/Slider/PositionDecorator.js 0.00% <0.00%> (ø)
packages/ui/Marquee/index.js 100.00% <0.00%> (ø)
... and 155 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d95ecbb...19f8a15. Read the comment docs.

@Djspaceg Djspaceg changed the title Add marqueeOn to MarqueeController Add marqueeOn prop to MarqueeController Jul 30, 2020
Blake Stephens added 2 commits July 30, 2020 10:28
Enact-DCO-1.0-Signed-off-by: Blake Stephens <[email protected]>
Enact-DCO-1.0-Signed-off-by: Blake Stephens <[email protected]>
@Djspaceg Djspaceg force-pushed the feature/marqueeoncontroller branch from e2f0e9b to 19f8a15 Compare July 30, 2020 17:28
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants