Feature: add new output tokens {consoleBrand}, {consoleName}, {consoleAbbrName}

[Djabal]

No description provided.

[github-actions]

👋 Welcome

Thank you for your first pull request, @Djabal! If you haven't yet, please familiarize yourself with igir's contribution guidelines.

Some GitHub Actions CI workflows may not automatically run for you due to GitHub's security best practices, so a maintainer may need to manually approve the workflows to run. As a result, it is important to make sure tests pass locally before submitting a pull request to help ensure a fast review. Thank you!

Comment generated by the GitHub First Interaction workflow.

[Djabal]

Hi,
A proposition to add new tokens console oriented.
Long time I haven't code anything, let me know if anything seems wrong.

[github-actions]

🧪 Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:Djabal/igir#patch-1" [commands..] [options]

Comment generated by the Node.js Branch Exec workflow.

[emmercm]

Hi @Djabal, thank you for the contribution!

[emmercm]

Do you know what No-Intro's intended use of the abbreviation is? This is the first time I've seen it. I see less value in it than in the other tokens, so I'm inclined to not add it.

[Djabal]

Hi @emmercm,

Thanks of Igir. Glad I can help with littles contributions.

In my opinion it's a simple way to have an human-readable ID. Easy to manipulate and to read, short, without space, without capital letter.

Many of these abbreviations are in the every-day speech (n64, snes, ps2, ...).

Many projects have their owns lists :

• Redump : http://wiki.redump.org/index.php?title=System_list
• Batocera : https://wiki.batocera.org/systems
• NineSheetMusic : https://www.ninsheetmusic.org/forum/index.php?topic=11423.0
• Video Game Music Preservation Foundation : https://www.vgmpf.com/Wiki/index.php?title=List_of_Platform_Abbreviations_(A-N)
• Romm : https://github.com/rommapp/romm/wiki/Supported-Platforms (not all are abbreviated, but all are ids)
• Es-de : https://gitlab.com/es-de/emulationstation-de/-/blob/master/USERGUIDE.md#supported-game-systems

Or use them without saying it :

• goodsets : goodn64, goodgg, goodspc, etc.
• adam : roms/GW, roms/PCE, roms/GG
• retrodeck
• onion

Other :

• https://en.wikibooks.org/wiki/History_of_video_games/List_of_Abbreviations

For me the main problem is to choose the goods abbreviations :

• easy way : it to choose to use No-Intro and Redump lists as there's no convention and no rules that you could extract from existing abbreviations.
• hard way : choose the bests abbreviations in all existing lists.
• weird way : don't care about all that and compute an id consistent with the console brand and name.

The easy way is for me the best as it reuses existing lists.

We can rename consoleAbbrName to consoleShortName or consoleID.

And it's make sense if it's required for all GameConsole too.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.18%. Comparing base (ec8d897) to head (7a86d6c).
Report is 15 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1202      +/-   ##
==========================================
+ Coverage   93.16%   93.18%   +0.01%     
==========================================
  Files         105      105              
  Lines        6486     6486              
  Branches     1538     1537       -1     
==========================================
+ Hits         6043     6044       +1     
- Misses        420      441      +21     
+ Partials       23        1      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.