Bring @glimmer/component into ember repo #20751
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| /* eslint-env node */ | ||
| 'use strict'; | ||
|
|
||
| const { addonV1Shim } = require('@embroider/addon-shim'); | ||
| module.exports = addonV1Shim(__dirname); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| { | ||
| "name": "@glimmer/component", | ||
| "version": "2.0.0", | ||
| "description": "Glimmer component library", | ||
| "exports": { | ||
| ".": "./dist/index.js" | ||
| }, | ||
| "keywords": [ | ||
| "ember-addon" | ||
| ], | ||
| "license": "MIT", | ||
| "contributors": [ | ||
| "Dan Gebhardt <[email protected]>", | ||
| "Robert Jackson <[email protected]>", | ||
| "Tom Dale <[email protected]>" | ||
| ], | ||
| "repository": "https://github.com/emberjs/ember.js", | ||
| "scripts": {}, | ||
| "dependencies": { | ||
| "@embroider/addon-shim": "^1.8.9", | ||
| "@glimmer/env": "^0.1.7" | ||
| }, | ||
| "devDependencies": { | ||
| "typescript": "5.1" | ||
| }, | ||
| "engines": { | ||
| "node": ">= 18" | ||
| }, | ||
| "typesVersions": { | ||
| "*": { | ||
| "*": [ | ||
| "dist/*" | ||
| ] | ||
| } | ||
| }, | ||
| "ember-addon": { | ||
|
There was a problem hiding this comment. since glimmer/component doesn't depend on any embery things, does it need to be an addon at all? There was a problem hiding this comment. I thought that too, but it imports from |
||
| "type": "addon", | ||
| "version": 2, | ||
| "main": "addon-main.cjs" | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| import { DEBUG } from '@glimmer/env'; | ||
| import type { Arguments, ComponentManager, ComponentCapabilities } from '@glimmer/interfaces'; | ||
| import { type default as BaseComponent, ARGS_SET } from './component'; | ||
|
|
||
| export interface Constructor<T> { | ||
| new (owner: unknown, args: Record<string, unknown>): T; | ||
| } | ||
|
|
||
| export default abstract class BaseComponentManager<GlimmerComponent extends BaseComponent> | ||
| implements ComponentManager<GlimmerComponent> | ||
| { | ||
| abstract capabilities: ComponentCapabilities; | ||
|
|
||
| private owner: unknown; | ||
|
|
||
| constructor(owner: unknown) { | ||
| this.owner = owner; | ||
| } | ||
|
|
||
| createComponent( | ||
| ComponentClass: Constructor<GlimmerComponent>, | ||
| args: Arguments | ||
| ): GlimmerComponent { | ||
| if (DEBUG) { | ||
| ARGS_SET.set(args.named, true); | ||
| } | ||
|
|
||
| return new ComponentClass(this.owner, args.named); | ||
| } | ||
|
|
||
| getContext(component: GlimmerComponent): GlimmerComponent { | ||
| return component; | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified that all the other package.jsons were also private.
Surprised this wasn't caught before -- but also not surprised -- because we're not using release-plan (or anything to enforce package.json consistency)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for now, we could very well set up release plan for just
@glimmer/componentif we wanted.