Backporting circularity fixes #20743
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is backporting https://github.com/emberjs/ember.js/pull/20734/files to current release (5.x).
ef4
added a commit
to embroider-build/embroider
that referenced
this pull request
Sep 7, 2024
This switching our tests from "lts_5_8" to "release" and locks the release into 5.11 plus my bugfix backport PR emberjs/ember.js#20743. I'm doing this because the circularity problems continue to be obnoxious, and some of the things I need to test are 5.x behaviors that are removed at 6.x.
|
@kategengler can we put this in 5.11.x patch? My motivation here is that the circularity bugs get in the way of testing apps under vite, and it's nice to not have to deal with their 6.0 upgrades simultaneously. |
|
I think we should backport to beta first. I can do it via the typical cherry-pick unless you think there are a lot of conflicts? |
|
Probably no conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is backporting https://github.com/emberjs/ember.js/pull/20734/files to current release (5.x).