[experiment]: Demo app for glimmer-next renderer #20711
Conversation
| @@ -1,7 +1,10 @@ | |||
| import type { InternalOwner } from '@ember/-internals/owner'; | |||
| import type { Helper, HelperDefinitionState } from '@glimmer/interfaces'; | |||
| import { setInternalHelperManager } from '@glimmer/manager'; | |||
| // import { setInternalHelperManager } from '@glimmer/manager'; | |||
There was a problem hiding this comment.
why comment this out?
If we need to re-define the implementation, I think that could happen in this PR (like, if it's copying from glimmer-next, for example)
| @@ -4,6 +4,7 @@ import type { InternalOwner } from '@ember/-internals/owner'; | |||
| import { getOwner } from '@ember/-internals/owner'; | |||
| import { guidFor } from '@ember/-internals/utils'; | |||
| import { getViewElement, getViewId } from '@ember/-internals/views'; | |||
| import { renderComponent } from '@lifeart/gxt'; | |||
There was a problem hiding this comment.
we should pull this in to the repo (easier maintenance!)
| @@ -0,0 +1,58 @@ | |||
| import { Component } from '@lifeart/gxt'; | |||
There was a problem hiding this comment.
why not @glimmer/component (not the real glimmer component, but re-defined in this PR, using glimmer-next apis?)
There was a problem hiding this comment.
need to do some copy-paste from non-released branch - lifeart/glimmer-next#25
packages/demo/src/config/resolver.ts
Outdated
There was a problem hiding this comment.
why not use ember-resolver?
There was a problem hiding this comment.
@NullVoxPopuli it's basically copy pasta, without side deps (glimemer-debug, etc).
There was a problem hiding this comment.
you could provide @glimmer/debug in this PR :)
| @@ -0,0 +1,14 @@ | |||
| export function unwrapTemplate(tpl) { | |||
| return { | |||
| asLayout(){ | |||
There was a problem hiding this comment.
I could be misremembering the purpose of this...
But, I don't think layouts need support as template resolving outside of routes' templates is deprecated for removal in v6
There was a problem hiding this comment.
for now it's workaround related to existing template handing logic (from glimmer-vm).
compiled glimmer-vm template has special 'shape' and it's hardcoded in ember - we just providing compatible wrapper for it.
| } | ||
| ); | ||
| {{on 'click' this.click}} >{{yield}}</a>`; | ||
| } |
There was a problem hiding this comment.
What is the motivation for needing to rewrite these?
You could reimplement the meaning of precompileTemplate to be whatever you need it to be, and then you wouldn't need to touch this code and you would have a much greater chance of actually achieving upgrade compatibility.
There was a problem hiding this comment.
@ef4 this is just for experimentation purposes, I agree - we could keep same api as-is here (compiler need to be extended a bit)
|
|
||
| export default class ApplicationTemplate extends Component { | ||
| <template> | ||
| <header class="bg-blue-600 p-4"> |
There was a problem hiding this comment.
TODO: move to glimmer component
This is experiment to replace
@glimmer/*rendering and reactivity stack with lifeart/glimmer-nextDemo Application setup based on source from lifeart/demo-ember-vite
Check:
cd packages/demo/ rm -rf ./node_modules/.vite pnpm run devRoutes:
http://localhost:5173/profile
http://localhost:5173/
Working (somehow):
{{outlet}}Not working:
Screen.Recording.2024-07-01.at.16.13.54.mov