Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v2 backport] Pass owner instead of registry to ember-data's setupContainer #1388

Open
wants to merge 2 commits into
base: v2-x
Choose a base branch
from
Open

[v2 backport] Pass owner instead of registry to ember-data's setupContainer #1388

wants to merge 2 commits into from

Commits on May 12, 2023

  1. Pass owner instead of registry to ember-data's setupContainer 

    The `setupContainer` function of `ember-data` expects an application
instance to be passed - in this case that is the faked owner object that
we create when using a custom resolver in tests.

This behaviour previously worked because `ember-data` supported the
usage of legacy function `optionsForType` which exists on the `registry`
object. However, they removed that legacy fallback in v4 and replaced it
with `registerOptionsForType` which does not exist on the registry but
only on the owner.

Resolves emberjs#1386
    @anehx
    anehx committed May 12, 2023
    Configuration menu
    Copy the full SHA
    559144f View commit details
    Browse the repository at this point in the history

Commits on May 31, 2023

  1. chore(ci): fix CI pipelines for v2 backports channel

    @anehx
    anehx committed May 31, 2023
    Configuration menu
    Copy the full SHA
    9500d0b View commit details
    Browse the repository at this point in the history