Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup fallback codepaths for older Ember versions #1298

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Cleanup fallback codepaths for older Ember versions #1298

wants to merge 5 commits into from

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Dec 16, 2022

  • Remove supporting code for Ember < 4
  • Remove guards for supporting older Ember versions

@chriskrycho
Copy link
Contributor

This'll need a rebase/merge courtesy of merging #1299. I'll tackle it on Monday.

@chriskrycho
Merge remote-tracking branch 'origin/master' into older-ember-cleanup
83f7b8c 
# Conflicts:
#	tests/unit/dom/blur-test.js
#	tests/unit/dom/click-test.js
#	tests/unit/dom/double-click-test.js
#	tests/unit/dom/fill-in-test.js
#	tests/unit/dom/focus-test.js
#	tests/unit/dom/tab-test.js
#	tests/unit/dom/tap-test.js
@chriskrycho
Copy link
Contributor

Okay, that works… but now we have test failures because something isn't quite right in e34264e, I think. Will poke at it… after getting a whole bunch more deck-clearing done with Ember's types publishing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriskrycho chriskrycho chriskrycho approved these changes

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rwjblue @chriskrycho