Handle exceptions in hooks #210
Conversation
`beforeEach` and `afterEach` hooks are promised based and are called one after the other. If one of them raises an exception, the execution stops at that moment. This causes problems as it will prevent the tearing down of the test.
mupkoo
force-pushed
the
handle-exceptions-in-hooks
branch
from
1a0733a
to
907b1d6
Compare
| return promise | ||
| .then(fn.bind(context)) | ||
| // eslint-disable-next-line no-console | ||
| .catch((error) => console.error('Hook throws an error: ', error)); |
There was a problem hiding this comment.
Hmm, this will prevent getting a "break on exceptions" style breakpoint in your offending hook...
Can you double check?
There was a problem hiding this comment.
Pause on exception is working even if the exception is caught.
@rwjblue let me know if you have a better idea, how we can do this.
There was a problem hiding this comment.
In the screenshot you are using the checkbox for “pause on caught exceptions”. Maybe that’s just what you always have had to do (due to mochas usage of exceptions for flow control)?
There was a problem hiding this comment.
Sorry, it looks like I misunderstood you.
One thing that we can do is to just make sure that the teardown happens in all cases. Something like
afterEach(function() {
return chainHooks(afterEachHooks, this)
.finally(() => teardownContext(this))
.finally(() => {
// delete any extraneous properties
for (let key in this) {
if (!(key in originalContext)) {
delete this[key];
}
}
// copy over the original values
_assign(this, originalContext);
})
.catch((error) => { throw error });
});This way the errors that happen in the hooks will be returned to mocha, but we would have cleared the test context.
There was a problem hiding this comment.
Not a fan of the idea?
beforeEachandafterEachhooks are promised based and are called one after the other. If one of them raises an exception, the execution stops at that moment. This causes problems as it will prevent the tearing down of the test.Related to #209
PS I had to update the test selectors, because I was not able to install them