Backport #8850 (Overwrite addMixin) #9218
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use addMixin * here too (cherry picked from commit 5a771b3)
because the deprecated code was removed in later versions - Remove the type definition for `hasMixin` on `ember` - Add a type definition for `addMixin` on `ember`
Baltazore
force-pushed
the
kg-backport-8850
branch
from
7e18a39
to
7d90816
Compare
Baltazore
reviewed
May 11, 2024
| @@ -71,9 +71,17 @@ export default class PromiseManyArray { | |||
| } | |||
| return false; | |||
| }; | |||
| meta.addMixin = (mixin: object) => { | |||
| deprecate(`Do not use A() on an EmberData PromiseManyArray`, false, { | |||
There was a problem hiding this comment.
@runspired I had to put deprecation call here for both hasMixin and addMixin to satisfy the tests... Not sure if this is the correct approach...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #8850 to LTS 4.12
use addMixin
here too
(cherry picked from commit 5a771b3)