OCaml: Add type enclosing #4741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
client
mattiasdrp
force-pushed
the
mattias@ocaml-lsp-type-enclosing
branch
7 times, most recently
from
a32b3b4 to
2fd1ac3
Compare
|
This PR is now ready. It implements functions using the custom request defined in https://github.com/ocaml/ocaml-lsp/blob/master/ocaml-lsp-server/docs/ocamllsp/typeEnclosing-spec.md |
mattiasdrp
force-pushed
the
mattias@ocaml-lsp-type-enclosing
branch
4 times, most recently
from
a3991e7 to
e1e880c
Compare
7 tasks
|
I'm a bit confused. Does the https://github.com/freebroccolo/ocaml-language-server no longer work? It returns 404 now. 😕 Should we remove it? Can you rebase to resolve the conflict? Thanks! 😋 |
I don't know anyone that uses it and it hasn't been maintained for the last 8 years so I think it could be removed, yes |
|
Can you fix the CI? Thank you! |
mattiasdrp
force-pushed
the
mattias@ocaml-lsp-type-enclosing
branch
from
3f000d0 to
43220c0
Compare
Should be ok now ;-) |
This also creates a transient keymap allowing to: - increase/decrease the verbosity of the displayed type - copy the computed type - Increase/Decrease index - Show the region that is currently being typed
…nature This function was useful because textDocument/hover returned the type and documentation of the identifier at point making it hard to kill the type only Now that ocamllsp/typeEnclosing is used instead there is no reason to keep this poorly written function (I was young and innocent)
CHANGELOG updated
mattiasdrp
force-pushed
the
mattias@ocaml-lsp-type-enclosing
branch
from
43220c0 to
71a54fa
Compare
jcs090218
approved these changes
Mar 31, 2025
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second of a series of PR I aim to do to improve the ocaml-lsp experience in lsp-mode
This PR exposes
lsp-ocaml-type-enclosingthat allows to get the type at point and improve itThis is still a draft PR because I need to add more verbosity and index options allowing to show types behind aliases and much more
This PR is based on #4732 and shouldn't be merged until the first one is