Use Test Modules in tests instead of Elixir built-in modules #14383
Conversation
Prep for Coverage Reporting in tests
There was a problem hiding this comment.
Let's please move this one to test/elixir/test/elixir/path_helpers.exs, as it is exclusive to tests file, and we typically keep assorted scripts in path_helpers.exs. :)
There was a problem hiding this comment.
Now that I think about it, I would not extract it to a separate file, given the coupling and the fact we probably only need to share the write_beam() function?
Also, if you search for write_beam =, you can also see another place that we define a function for testing.
|
|
||
| defmodule PathHelpers do | ||
| def fixture_path() do | ||
| Path.expand("../test/elixir/fixtures", __DIR__) |
There was a problem hiding this comment.
This would be leaking Elixir fixtures to other test suites.... I am not sure we want to do that.
| def redirect_std_err_on_win, do: "" | ||
| end | ||
| end | ||
| Code.eval_file("../../scripts/path_helpers.exs", __DIR__) |
There was a problem hiding this comment.
| Code.eval_file("../../scripts/path_helpers.exs", __DIR__) | |
| Code.require_file("../../scripts/path_helpers.exs", __DIR__) |
| @@ -2,6 +2,8 @@ | |||
| # SPDX-FileCopyrightText: 2021 The Elixir Team | |||
| # SPDX-FileCopyrightText: 2012 Plataformatec | |||
|
|
|||
| Code.eval_file("../../elixir/scripts/path_helpers.exs", __DIR__) | |||
There was a problem hiding this comment.
| Code.eval_file("../../elixir/scripts/path_helpers.exs", __DIR__) | |
| Code.require_file("../../elixir/scripts/path_helpers.exs", __DIR__) |
| @@ -103,3 +105,32 @@ defmodule IEx.Case do | |||
| |> String.trim() | |||
| end | |||
| end | |||
|
|
|||
| PathHelpers.write_beam( | |||
There was a problem hiding this comment.
Create a write_beam specific to IEx and have it already purge and delete the modules for you :)
| File.mkdir_p!(unquote(path)) | ||
| beam_path = Path.join(unquote(path), Atom.to_string(name) <> ".beam") | ||
| File.write!(beam_path, bin) | ||
| res |
There was a problem hiding this comment.
Let's purge/delete it by default too.
There was a problem hiding this comment.
Thank you @maennchen. Sorry I left the comments a bit everywhere but the summary is to not extract PathHelpers to a different module, let's simply defined it for the IEx suite instead, and let's make it automatically purges and deletes modules, so we don't have to explicitly call it every time.
Prep for #14343