Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MultitaskingView: cleanup and bugfixes #1787

Merged
merged 9 commits into from
Nov 7, 2023
Merged

MultitaskingView: cleanup and bugfixes #1787

merged 9 commits into from
Nov 7, 2023

Conversation

lenemter
Copy link
Member

@lenemter lenemter commented Oct 28, 2023 •
edited
Loading

  • Don't disable gesture tracker as it can stuck if you switch workspace and immediately close the multitasking view
  • Switch to target workspace early
  • Use Meta.Workspace objects directly instead of dealing with their indexes

@lenemter lenemter requested a review from a team October 28, 2023 05:59
@lenemter lenemter mentioned this pull request Oct 28, 2023
Merged
danirabbit
danirabbit approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that closing immediately after switching can end up breaking gestures and I can't reproduce that in this branch 🚀

@danirabbit danirabbit merged commit 27cc39c into master Nov 7, 2023
4 checks passed
@danirabbit danirabbit deleted the lenemter/multitasking-view-improvements branch November 7, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danirabbit danirabbit danirabbit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
OS 8
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lenemter @danirabbit