Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Peeking unknown rooms #1037

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Peeking unknown rooms #1037

wants to merge 10 commits into from

Commits on Feb 15, 2023

  1. define PeekableRoomView and make UnknownRoomViewModel handle it

    @ashfame
    ashfame committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    d468abd View commit details
    Browse the repository at this point in the history

  2. setup timelineViewModel on unknownRoomViewModel to render the timelin… 

    …e by fetching messages and storing in the indexed db tables
    @ashfame
    ashfame committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    8b56a0d View commit details
    Browse the repository at this point in the history

  3. move room alias resolution to canPeekInRoom() instead

    @ashfame
    ashfame committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    9fa2f71 View commit details
    Browse the repository at this point in the history

  4. use css to hide the right panel triggered when clicked on user avatar… 

    … in a message
    @ashfame
    ashfame committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    c76e45d View commit details
    Browse the repository at this point in the history

  5. remove PeekableRoomView and bring the code for it within UnknownRoomV… 

    …iew only
    @ashfame
    ashfame committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    5bc5ca0 View commit details
    Browse the repository at this point in the history

  6. change code to refer peekable room as WorldReadable room to be more a… 

    …ligned with Matrix spec
    @ashfame
    ashfame committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    4439fb3 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2023

  1. use string's startsWith() instead 

    Co-authored-by: Paulo Pinto <[email protected]>
    @ashfame @psrpinto
    ashfame and psrpinto committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    220fe38 View commit details
    Browse the repository at this point in the history

  2. ensure a boolean is returned despite of failure/error in HomeserverAp… 

    …i HTTP request
    @ashfame
    ashfame committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    2fb9cb6 View commit details
    Browse the repository at this point in the history

  3. improve UX when joining big rooms to render unknown room view early a… 

    …nd loading things async and updating view as we do

This shows a spinner on UnknownRoomView stating "checking preview capability" and goes away when done
and if room is world_readable, then renders the timeline with the last 100 messages
    @ashfame
    ashfame committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    654cdf0 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2023

  1. separate view and model for WorldReadableRoom out of UnknownRoom 

    - UnknownRoomViewModel now receives a promise using which it can display a spinner to the user indicating we are checking whether the preview is possible for this room
and updates the model to WorldReadableRoomViewModel
- kind is now changed to "preview" for WorldReadableRooms
- data stored is now deleted when navigating away to another room by clicking on it
    @ashfame
    ashfame committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    07cce38 View commit details
    Browse the repository at this point in the history