Fix identity server input not showing errors #29272
Draft
+28
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Half-Shot
changed the title
Half-Shot
changed the title
Half-Shot
commented
Feb 14, 2025
| @@ -393,28 +374,27 @@ export default class SetIdServer extends React.Component<IProps, IState> { | |||
|
|
|||
| return ( | |||
| <SettingsFieldset legend={sectionTitle} description={bodyText}> | |||
| <form className="mx_SetIdServer" onSubmit={this.checkIdServer}> | |||
| <Field | |||
| <TooltipProvider> | |||
There was a problem hiding this comment.
I decided that rather than trying to work around Field's validiity, we should just update this setting to use EditInPlace. This means we're using a Compound component, with support for asynchronous actions and built in support for progress and error text.
Ultimately this feels like a much better change.
Half-Shot
commented
Feb 14, 2025
| @@ -60,8 +60,6 @@ interface IProps { | |||
| // If specified, contents will appear as a tooltip on the element and | |||
| // validation feedback tooltips will be suppressed. | |||
| tooltipContent?: JSX.Element | string; | |||
| // If specified the tooltip will be shown regardless of feedback | |||
| forceTooltipVisible?: boolean; | |||
There was a problem hiding this comment.
This PR deprecates the last user of forceTooltipVisible. Given it's a force flag, it feels reasonably okay to remove it and encourage using mode modern components.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a bug where the identity server input field would not show a tooltip on error as it does not use the same validation logic (for good reason, there may be a user input stage in the middle for terms and conditions acceptance).
The change would have been to adapt the existing
Fieldto useforceTooltipVisible(d82029d) but given Compound offers a better component for this sort of thing, I switched theFieldforEditInPlace.There was one other usage of
forceTooltipVisiblewhich was being used for informational purposes. Since it was used for a settings flag, I've simply given that settings flag adescriptionand used the new settings togglebox to reduce one usage offorceTooltipVisible.Checklist
public/exportedsymbols have accurate TSDoc documentation.