Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LSN comparison #2426

Merged
merged 2 commits into from
Mar 7, 2025
Merged

Fix LSN comparison #2426

merged 2 commits into from
Mar 7, 2025

Conversation

robacourt
Copy link
Contributor

Following on from #2423 , this fixes another comparison.

@robacourt robacourt marked this pull request as ready for review March 6, 2025 19:50
@robacourt robacourt requested a review from msfstef March 6, 2025 19:50
msfstef
msfstef approved these changes Mar 7, 2025
View reviewed changes
Copy link
Contributor

@msfstef msfstef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, missed that one! In hindsight, we probably are better off converting the Lsn to an integer early on and do these comparisons, but we can do that after fixing this

@robacourt robacourt merged commit 21a3b93 into main Mar 7, 2025
34 checks passed
@robacourt robacourt deleted the rob/lsn-fix branch March 7, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msfstef msfstef msfstef approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robacourt @msfstef