Fix: Fixed auto complete not working due to missing raw hit #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 CLA has been signed |
|
🚀 Built search-ui successfully!
|
|
Signed |
|
thanks for the fix! I added a small test to verify the option is being passed through. |
joemcelroy
approved these changes
Apr 25, 2022
joemcelroy
added a commit
to joemcelroy/search-ui
that referenced
this pull request
Jan 10, 2023
) * Fix: Fixed auto complete not working due to missing raw hit * Fix: fixed buikd error * add test to verify includeRawHit is being called Co-authored-by: Joseph McElroy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the autocomplete feature broken by #715 , Autocomplete query doesn't include raw hit which broke it.
List of changes
Change to include Rawhit in autocomplete response of elastic search connector,
Associated Github Issues
#704