Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin manager: add --no-expand flag for list command #17124

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

yaauie
Copy link
Member

@yaauie yaauie commented Feb 20, 2025

Release notes

  • The plugin manager bin/logstash-plugin's list command now supports a --no-expand flag to avoid expanding plugin aliases and the individual plugins within integration plugins.

What does this PR do?

Adds --[no-]expand flag (default: true) to the plugin manager's list command, so that a caller can avoid expanding the integration plugins and aliases to get only a list of the plugin packages installed.

Why is it important/What is the impact to the user?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [] I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • file doc issue

How to test this PR locally

bin/logstash-plugin list --no-expand
bin/logstash-plugin list --verbose --no-expand
bin/logstash-plugin list --no-expand logstash-integration-aws
bin/logstash-plugin list --no-expand --verbose logstash-integration-aws

Allows us to avoid expanding aliases and integration plugins
@yaauie
Copy link
Member Author

yaauie commented Feb 20, 2025

Test failure is due to encoding conversions on a shell that apparently isn't UTF-8. I can rephrase the failing test.

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

Copy link
Member

@donoghuc donoghuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants