Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [ES UI Shared] Remove 'brace' from es_ui_shared public (#78033) #78427

Merged
merged 6 commits into from
Sep 28, 2020

Commits on Sep 24, 2020

  1. [ES UI Shared] Remove 'brace' from es_ui_shared public (elastic#78033)

    * major wip
    
    * major wip
    
    * fix worker creation leak
    
    * just copy the file over for now
    
    * Remove xjson from static and from es_ui_shared entirely
    
    - moved expand and collapse logic back to es_ui_shared. It has
      nothing to do with ace
    - refactor the useXJson hook which bundled XJsonMode with it.
      This was convenient but ultimately inflates the amount of code
      Kibana needs to first load up in the client. Users will need to
      import XJsonMode and instantiate it when they want to use it.
      Updated existing usage.
    - Cleaned up Monaco namespace from es_ui_shared because of how
      useXJsonMode was refactored -- no longer exporting an editor
      specific instance means this code does not know about anything
      to do with code editors so it is decoupled from ace and monaco.
    
    * fix export of collapse and expand string literals
    
    Co-authored-by: Elastic Machine <[email protected]>
    # Conflicts:
    #	.github/CODEOWNERS
    #	src/plugins/es_ui_shared/kibana.json
    jloleysens committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    af6bdb0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7d05a82 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e69c8e3 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2020

  1. Configuration menu
    Copy the full SHA
    f38d66c View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2020

  1. Configuration menu
    Copy the full SHA
    393a648 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c8c7825 View commit details
    Browse the repository at this point in the history