[controls] fix timeslider control not filtering dashboard panels #145184
Conversation
nreese
changed the title
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
nreese
added
Team:Presentation
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
| @@ -11,6 +11,7 @@ import React from 'react'; | |||
| import ReactDOM from 'react-dom'; | |||
| import { compareFilters, COMPARE_ALL_OPTIONS, Filter, uniqFilters } from '@kbn/es-query'; | |||
| import { BehaviorSubject, merge, Subject, Subscription } from 'rxjs'; | |||
| import _ from 'lodash'; | |||
There was a problem hiding this comment.
Honest question, because I really don't know. Would import { isEqual } from 'lodash'; be any better for compilation or performance?
There was a problem hiding this comment.
I found this article which demonstrates that either method produces the same bundle size. I am not sure how the 2 methods effect compilation speed.
There was a problem hiding this comment.
Makes sense. Looks like we also have lodash in @kbn/ui-shared-deps-src. And I've found more context here. tldr; don't import from 'lodash/*.
#140739 caused a regression with timeslider control where
ControlGroupContainerwas not not firingupdateOutputonoutput.timeslicechanges.This PR resolves the regression and adds functional tests to ensure interactions with timeslider properly flow to dashboard saved search panel