Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crowdstrike: deflake test #12848

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

crowdstrike: deflake test #12848

wants to merge 1 commit into from

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Feb 20, 2025

Proposed commit message

crowdstrike: deflake test

The final test sample in fdr-sample.log for the tf deployer added in #11023
does not have a timestamp. This allows the the event to be ingested multiple
times since in the absence of an explicit timestamp, the @timestamp value is
constructed from ingest time. Since the test case was added for reasons other
than timestamp existence, the fix here just adds a timestamp.

Note

No changelog entry as the change is not user-facing.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6
crowdstrike: deflake test
9fec18f 
The final test sample in fdr-sample.log for the tf deployer added in elastic#11023
does not have a timestamp. This allows the the event to be ingested multiple
times since in the absence of an explicit timestamp, the @timestamp value is
constructed from ingest time. Since the test case was added for reasons other
than timestamp existence, the fix here just adds a timestamp.
@efd6 efd6 added Integration:crowdstrike CrowdStrike bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] labels Feb 20, 2025
@efd6 efd6 self-assigned this Feb 20, 2025
@elasticmachine
Copy link

💚 Build Succeeded

cc @efd6

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@efd6 efd6 marked this pull request as ready for review February 20, 2025 06:07
@efd6 efd6 requested a review from a team as a code owner February 20, 2025 06:07
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@efd6 efd6

Labels
bugfix Pull request that fixes a bug issue Integration:crowdstrike CrowdStrike Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations]
Projects
None yet
Milestone
No milestone
2 participants
@efd6 @elasticmachine