jamf_pro: normalize jamf_pro.inventory.operating_system.version and os.version to three-part versions #12834
+235
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
enhancement
efd6
force-pushed
the
12799-jamf_pro
branch
2 times, most recently
from
65f6d87 to
cc55317
Compare
efd6
commented
Feb 19, 2025
| "rapidSecurityResponse": null, | ||
| "softwareUpdateDeviceId": "J314cAP", | ||
| "supplementalBuildVersion": "23H311", | ||
| "version": "14.7" |
| "name": "macOS", | ||
| "software_update_device_id": "J314cAP", | ||
| "supplemental_build_version": "23H311", | ||
| "version": "14.7.0" |
| }, | ||
| "os": { | ||
| "name": "macOS", | ||
| "version": "14.7.0" |
| "rapidSecurityResponse": null, | ||
| "softwareUpdateDeviceId": "J314cAP", | ||
| "supplementalBuildVersion": "23H311", | ||
| "version": "14" |
| "name": "macOS", | ||
| "software_update_device_id": "J314cAP", | ||
| "supplemental_build_version": "23H311", | ||
| "version": "14.0.0" |
| }, | ||
| "os": { | ||
| "name": "macOS", | ||
| "version": "14.0.0" |
🚀 Benchmarks reportTo see the full report comment with |
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
…s.version to three-part versions Depending on the source of the Jamf data, we may receive two-part (e.g. 15.1) or three-part (e.g. 15.1.0) versions for versions where the last part is zero. This leads to multiplication of the numbers of semantically identical versions in search results and dashboards. So normalise all OS versions to the three-part form, unless there are other syntax components (this should never happen).
💚 Build Succeeded
History
cc @efd6 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Note
The dashboard uses
jamf_pro.inventory.operating_system.version, so this why we need to change both.Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots