Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[o365_metrics]Update ownership for O365 Metrics integration #12814

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

narph
Copy link
Contributor

@narph narph commented Feb 17, 2025

Update ownership for O365 Metrics integration
Currently some of the data streams are owned by the @elastic/security-service-integrations because they were created by one of the team members.
All the data streams that the security team owns:

  • /packages/o365_metrics/data_stream/groups_activity_group_detail
  • /packages/o365_metrics/data_stream/onedrive_usage_account_detail
  • /packages/o365_metrics/data_stream/teams_user_activity_user_detail
  • /packages/o365_metrics/data_stream/viva_engage_groups_activity_group_detail

Based on the integration name and scope and looking at the sample logs:
https://github.com/elastic/integrations/blob/main/packages/o365_metrics/data_stream/groups_activity_group_detail/sample_event.json
https://github.com/elastic/integrations/blob/main/packages/o365_metrics/data_stream/onedrive_usage_account_detail/sample_event.json
https://github.com/elastic/integrations/blob/main/packages/o365_metrics/data_stream/teams_user_activity_user_detail/sample_event.json
https://github.com/elastic/integrations/blob/main/packages/o365_metrics/data_stream/viva_engage_groups_activity_group_detail/sample_event.json

the data streams return exclusively metrics (specifically count and duration) and not logs or security information.

@kcreddy feel free to chime in here.

@lalit-satapathy do you see any reason the service team should continue owning these data streams?

@narph narph added Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] labels Feb 17, 2025
@narph narph requested a review from a team February 17, 2025 14:50
@elasticmachine
Copy link

💚 Build Succeeded

@kcreddy
Copy link
Contributor

kcreddy commented Feb 17, 2025

Thanks @narph for creating this.

It makes sense to divide the ownership based on the data domain instead of development team. All of the data in the mentioned data-streams pertains to Microsoft 365 Reports and are thus related to metrics. These shouldn't have been split up into data-stream based ownership to begin with.

In these 4 data-streams, the ingest pipelines and field naming convention are closely aligned with existing observability-owned data-streams. The CEL input program is slightly different and built based around user requirements. But that shouldn't be reason for security to own these data-streams IMO as data is metrics based.

Also when it comes to future enhancements for these data-streams such as enabling TSDS, observability has better guidance in executing these tasks rather than security.

@narph narph self-assigned this Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants