Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AmazonMQ] ActiveMQ metrics dataset of AmazonMQ #12807

Merged
merged 11 commits into from
Feb 21, 2025

Conversation

agithomas
Copy link
Contributor

  • Enhancement

Proposed commit message

Add new dataset for ActiveMQ managed by AmazonMQ

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • Integration test
  • Data validation test
  • Data isolation verification (RabbitMQ metrics vs ActiveMQ metrics)

How to test this PR locally

  • elastic-package build
  • elastic-package stack up -v -d --services package-registry

Screenshots

The dashboard is not part of the initial release.

@agithomas agithomas self-assigned this Feb 17, 2025
@agithomas agithomas added Integration:aws AWS Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] enhancement New feature or request labels Feb 17, 2025
@agithomas agithomas marked this pull request as ready for review February 17, 2025 16:16
@agithomas agithomas requested a review from a team February 18, 2025 04:51
type: long
description: The maximum number of clients you can connect to your broker using WebSocket.
# TotalEnqueueCount.sum and TotalDequeueCount.sum does not hold a queue or topic dimension and hence it is considered as a broker metrics.
# aws.amazonmq.metrics.activemq.destination(TotalEnqueueCount.sum | TotalEnqueueCount.sum) is included to align with the AWS documentation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(TotalEnqueueCount.sum | TotalEnqueueCount.sum)

Why this needs to be aligned with AWS documentation? Is this additional metrics which is not in the broker?

Also fix the TotalEnqueueCount.sum appears twice.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual behaviour of the the available dimension field for this metrics differs from what is mentioned in the documentation.

I have intentionally added TotalEnqueueCount.max, as part of two separate field groups. The destination field group would have more dimensions (additionally topic and queue) compared to broker field group. If for some reason the behaviour is updated as mentioned in the documentation, it would lead to data loss due to TSDS enablement. So, a safeguard mechanism if followed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a small mistake in the comment which i will update soon. It must be .max instead of .sum.

Copy link

Quality Gate failed Quality Gate failed

Failed conditions
25.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @agithomas

Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agithomas agithomas merged commit 54c000a into elastic:main Feb 21, 2025
5 of 6 checks passed
@elastic-vault-github-plugin-prod

Package aws_mq - 0.1.0 containing this change is available at https://epr.elastic.co/package/aws_mq/0.1.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:aws AWS Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants