-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AmazonMQ] ActiveMQ metrics dataset of AmazonMQ #12807
[AmazonMQ] ActiveMQ metrics dataset of AmazonMQ #12807
Conversation
packages/aws_mq/data_stream/activemq_metrics/elasticsearch/ingest_pipeline/default.yml
Show resolved
Hide resolved
type: long | ||
description: The maximum number of clients you can connect to your broker using WebSocket. | ||
# TotalEnqueueCount.sum and TotalDequeueCount.sum does not hold a queue or topic dimension and hence it is considered as a broker metrics. | ||
# aws.amazonmq.metrics.activemq.destination(TotalEnqueueCount.sum | TotalEnqueueCount.sum) is included to align with the AWS documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(TotalEnqueueCount.sum | TotalEnqueueCount.sum)
Why this needs to be aligned with AWS documentation? Is this additional metrics which is not in the broker?
Also fix the TotalEnqueueCount.sum appears twice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The actual behaviour of the the available dimension field for this metrics differs from what is mentioned in the documentation.
I have intentionally added TotalEnqueueCount.max
, as part of two separate field groups. The destination
field group would have more dimensions (additionally topic
and queue
) compared to broker
field group. If for some reason the behaviour is updated as mentioned in the documentation, it would lead to data loss due to TSDS enablement. So, a safeguard mechanism if followed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a small mistake in the comment which i will update soon. It must be .max
instead of .sum
.
|
💚 Build Succeeded
History
cc @agithomas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Package aws_mq - 0.1.0 containing this change is available at https://epr.elastic.co/package/aws_mq/0.1.0/ |
Proposed commit message
Add new dataset for ActiveMQ managed by AmazonMQ
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Screenshots
The dashboard is not part of the initial release.