Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing region config to aws-s3 in custom aws logs #11128

Closed
wants to merge 1 commit into from
Closed

Add missing region config to aws-s3 in custom aws logs #11128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/aws_logs/data_stream/generic/agent/stream/aws-s3.yml.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,9 @@ api_timeout: {{api_timeout}}
{{#if endpoint}}
endpoint: {{endpoint}}
{{/if}}
{{#if region}}
region: {{region}}
{{/if}}
{{#if default_region}}
default_region: {{default_region}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the ER conversation, there is already default_region so I believe having region here is redundant

{{/if}}
Expand Down
8 changes: 8 additions & 0 deletions packages/aws_logs/manifest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,14 @@ vars:
show_user: false
default: ""
description: URL of the entry point for an AWS web service
- name: region
type: text
title: Region
multi: false
required: false
show_user: false
default: ""
description: The name of the AWS region of the endpoint
- name: default_region
type: text
title: Default AWS Region
Expand Down