Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sync replace directives with beats #6738

Merged
merged 4 commits into from
Feb 7, 2025

Conversation

kruskall
Copy link
Member

@kruskall kruskall commented Feb 7, 2025

What does this PR do?

ensure replace directives are synced with beats

Why is it important?

try to resolve dependabot updates

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@kruskall kruskall requested a review from a team as a code owner February 7, 2025 01:30
Copy link
Contributor

mergify bot commented Feb 7, 2025

This pull request does not have a backport label. Could you fix it @kruskall? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Feb 7, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@pierrehilbert pierrehilbert added backport-8.x Automated backport to the 8.x branch with mergify backport-9.0 Automated backport to the 9.0 branch labels Feb 7, 2025
@kruskall kruskall removed the backport-8.x Automated backport to the 8.x branch with mergify label Feb 7, 2025
@kruskall
Copy link
Member Author

kruskall commented Feb 7, 2025

8.x has different replace directives, I can open a separate PR for that 🙂

@pierrehilbert
Copy link
Contributor

Sorry my bad, I didn't check before adding the backport label.

@kruskall kruskall enabled auto-merge (squash) February 7, 2025 14:50
go.mod Show resolved Hide resolved
@pkoutsovasilis pkoutsovasilis self-requested a review February 7, 2025 14:57
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@kruskall kruskall merged commit dd6918c into elastic:main Feb 7, 2025
14 checks passed
@kruskall kruskall deleted the fix/sync-replace branch February 7, 2025 17:17
mergify bot pushed a commit that referenced this pull request Feb 7, 2025
* fix: sync replace directives with beats

* lint: regenerate notice file

(cherry picked from commit dd6918c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-9.0 Automated backport to the 9.0 branch skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants