Bump the version on main to 9.1.0

[elastic-vault-github-plugin-prod]

No description provided.

[jlind23]

@rdner do you know how to fix this error?
failed to find a previous minor on the version list  

[rdner]

@jlind23 we cannot fix this error until we release 9.0.0 and 9.1.0 (we require 2 previous minor versions for testing), but we can either change it to a warning or comment this line:

elastic-agent/magefile.go

Line 2049 in 4d98382

PreviousMinors: 2,

[jlind23]

thanks @rdner! 9.0.0 and 9.1.0 will need to be available as snapshot and not as official release? If that's true then this PR will need to be merged anyway in order to get a 9.1.0 built.
cc @pchila @pkoutsovasilis as you might have other opinions here.

[rdner]

Previous minor requirement is about released versions, not snapshots. We need to comment this line

elastic-agent/magefile.go

Line 2049 in 4d98382

PreviousMinors: 2,

in order to proceed. We will return it set to 1 when 9.1.0 is officially released, we set it to 2 when 9.2.0 is officially released.

[pkoutsovasilis]

about the unit-tests @pchila is looking at that. About the integration failing tests @jlind23 can we do something similar that we did in the past like here to force them to run in 9.0.0-SNAPSHOT?

[pchila]

The unit tests are looking at the "real" version written in testing/integration/testdata/.upgrade-test-agent-versions.yml loaded in a global variable in init(): that is not a very flexible unit test setup.

The unit test should use some constant mock data just to test the logic of the PreviousMinor() function (including the case where there are not enough previous minors).

To solve the unit test problem we should remove the global state from the unit tests to be able to pass in the necessary test data.

There's then the behaviour that PreviousMinor() should have in case there are not enough versions which I think should be signaled by returning a specific error (ErrNotEnoughVersions or something) handled by the test runner in integration tests by emitting a warning (obviously a new unit test should be added for this).

@rdner , as the author of this part of code, what do you think about these 2 proposals?

In the short term, sadly I think we can only:

• disable the unit test (skip it)
• change the number of previous versions as proposed by @rdner but I think that it would have an effect on the version bump automation for upgrade integration tests

[jlind23]

So:

• For the integration tests lets override the version temporarily just like we did here as offered by @pkoutsovasilis
• For the unit test it is probably easier to skip them until we have a snapshot available for both.

[pchila]

• For the unit test it is probably easier to skip them until we have a snapshot available for both.

For the unit test we don't need to wait for the snapshot available, we could just fix the tests to not use real data. I am also not so sure that the error we see in the unit tests will not impact integration tests.

Will add a commit to skip the unit test for the moment and then we'll see.

Edit: created #6667 to track this

[rdner]

In my opinion, we should just hardcode the latest 8.x minor (e.g. 8.17) for now.

Here

elastic-agent/testing/upgradetest/versions.go

Lines 235 to 265 in 4d98382

	func PreviousMinor() (*version.ParsedSemVer, error) {
	versions, err := GetUpgradableVersions()
	if err != nil {
	return nil, fmt.Errorf("failed to get upgradable versions: %w", err)
	}
	current, err := version.ParseVersion(define.Version())
	if err != nil {
	return nil, fmt.Errorf("failed to parse the current version %s: %w", define.Version(), err)
	}
	// Special case: if we are in the first release of a new major (so vX.0.0), we should
	// return the latest release from the previous major.
	if current.Minor() == 0 && current.Patch() == 0 {
	// Since the current version is the first release of a new major (vX.0.0), there
	// will be no minor versions in the versions list from the same major (vX). The list
	// will only contain minors from the previous major (vX-1). Further, since the
	// version list is sorted in descending order (newer versions first), we can return the
	// first item from the list as it will be the newest minor of the previous major.
	return versions[0], nil
	}
	for _, v := range versions {
	if v.Prerelease() != "" || v.BuildMetadata() != "" {
	continue
	}
	if v.Major() == current.Major() && v.Minor() < current.Minor() {
	return v, nil
	}
	}
	return nil, ErrNoPreviousMinor
	}

[jlind23]

Force merging to unblock the unified release. We will follow up in a separate PRs to fix the integration tests.

[elastic-sonarqube]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube