-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIPS Build #6565
base: main
Are you sure you want to change the base?
FIPS Build #6565
Conversation
This pull request does not have a backport label. Could you fix it @michel-laterman? 🙏
|
|
a9b4565
to
3f18bfc
Compare
3f18bfc
to
9217e60
Compare
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
|
This should come with a test that the binary we produce actually works, ideally one that can confirm it properly uses the FIPS OpenSSL in the expected way. You'll also need to update CI to actually build the FIPS variant, the package steps for testing are in
|
What does this PR do?
Adds
FIPS
env var to magefile to enable FIPS compliant builds using the microsoft/go toolchain.This PR will not be sufficient to ensure that every artifact made with these changes are compliant, we still need to verify our crypto use.
Why is it important?
FIPS artifacts must be built with compliant toolchains.
Checklist
I have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksI have added an entry in./changelog/fragments
using the changelog toolI have added an integration test or an E2E testDisruptive User Impact
None
How to test this PR locally
Assuming microsoft go is available, run
FIPS=true mage build:binary